stevenschlansker

Independent general review, round 3

• Reviewer: fresh-context Claude subagent (Opus 5.5), independent general reviewer under the AGENTS.md carve-out; not given .agents/ci-and-pr.md or any Fory review checklist
• Reviewed: commit 5ff273c41, git diff apache/main...HEAD with apache/main at 63f8a9cd1
• Date: 2026-11-08
• Mode: read-only (no builds or edits)

Reviewer report (verbatim)

Verdict: CLEAN

stevenschlansker

PR 3714 final AI review, round 4: independent general reviewer

• PR head reviewed: 8a1768e2cb6544fa6374c86d189df6d457d1be6b
• Diff: git diff 8e936331b 8a1768e2c (merge base with apache/main)
• Model: Claude Opus 5.5 (claude-opus-5-5), fresh read-only subagent in Claude Code
• Role: independent general reviewer per AI_POLICY.md section 5. Did not load .agents/ci-and-pr.md or any Fory-specific checklist (AGENTS.md independent-review carve-out). Ran no builds or tests.
• Inputs: the review worktree at the PR head, the PR description (as claims to check), and the paired benchmark and verification summary (as evidence).

---

stevenschlansker

Independent review of Apache Fory PR #4112

• Reviewer: Independent general reviewer (no Fory review checklist)
• Model: Claude Opus 5.5 (claude-opus-5-5)
• PR: #4112, "fix(java): run descriptor warm-up on Fory's compiler pool to fix thread context classloader"
• Reviewed commit: 8118a544f0a372c1d04a10cdb383f51162271189
• Base: 8e936331b (merge base with apache/main)
• Scope: review only. I read the changed code and its callers. I did not run builds or tests.

Summary

stevenschlansker

Apache Fory PR #4112: Fory-guided AI review

• PR: apache/fory#4112
• Reviewer: Fory-guided reviewer (AI_POLICY.md section 5), following AGENTS.md and .agents/ci-and-pr.md
• Model: Claude Opus 5.5 (claude-opus-5-5), xhigh effort, fresh clean-context session
• Reviewed head: e805b35d3eeb91ac04fe6ba8345752be91edd5e6
• Reviewed diff: git diff 7919241bc...e805b35d3 (merge base with apache/main to PR head)
• Date: 2026-10-17
• Verdict: No further actionable comments

stevenschlansker

package org.apache.fury.format.encoder;

import org.apache.fury.format.row.binary.*;
import org.apache.fury.format.row.binary.writer.*;
import org.apache.arrow.vector.types.pojo.*;
import org.apache.arrow.vector.types.pojo.Field;
import org.apache.arrow.vector.types.pojo.Schema;
import org.apache.fury.format.row.Row;
import org.apache.fury.format.row.ArrayData;
import org.apache.fury.format.row.MapData;

stevenschlansker

log4j:ERROR setFile(null,true) call failed.
java.io.FileNotFoundException: /home/zlandes/asn/log/scraper.log (No such file or directory)
	at java.base/java.io.FileOutputStream.open0(Native Method)
	at java.base/java.io.FileOutputStream.open(FileOutputStream.java:291)
	at java.base/java.io.FileOutputStream.<init>(FileOutputStream.java:234)
	at java.base/java.io.FileOutputStream.<init>(FileOutputStream.java:155)
	at org.apache.log4j.FileAppender.setFile(FileAppender.java:294)
	at org.apache.log4j.RollingFileAppender.setFile(RollingFileAppender.java:207)
	at org.apache.log4j.FileAppender.activateOptions(FileAppender.java:165)
	at org.apache.log4j.config.PropertySetter.activate(PropertySetter.java:307)

stevenschlansker

public class TestJdk12Regression {
    @FunctionalInterface
    interface HandleCallback<T, X extends Exception> {
        T withHandle(Handle handle) throws X;
    }
    @FunctionalInterface
    interface HandleConsumer<X extends Exception> {
        void useHandle(Handle handle) throws X;
    }

stevenschlansker

[INFO] Compiling 124 source files to /home/travis/build/jdbi/jdbi/core/target/test-classes
An exception has occurred in the compiler (12). Please file a bug against the Java compiler via the Java bug reporting page (http://bugreport.java.com) after checking the Bug Database (http://bugs.java.com) for duplicates. Include your program and the following diagnostic in your report. Thank you.
java.lang.NullPointerException
	at jdk.compiler/com.sun.tools.javac.comp.Flow$FlowAnalyzer.visitApply(Flow.java:1304)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1709)
	at jdk.compiler/com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:49)
	at jdk.compiler/com.sun.tools.javac.comp.Flow$BaseAnalyzer.scan(Flow.java:394)
	at jdk.compiler/com.sun.tools.javac.tree.TreeScanner.visitSelect(TreeScanner.java:308)
	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2189)
	at jdk.compiler/com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:49)

stevenschlansker

# JMH version: 1.21
# VM version: JDK 12, OpenJDK 64-Bit Server VM, 12+33
# VM invoker: /usr/lib/jvm/java-12-openjdk-12.0.0.33-1.ea.1.rolling.fc29.x86_64/bin/java
# VM options: <none>
# Warmup: <none>
# Measurement: 1 iterations, 120 s each
# Timeout: 10 min per iteration
# Threads: 1 thread, will synchronize iterations
# Benchmark mode: Throughput, ops/time
# Benchmark: com.fasterxml.jackson.module.blackbird.Afterburner.beanArrayDeser

stevenschlansker

Benchmark                          Mode  Cnt   Score   Error  Units
Afterburner.beanArrayDeser           ss   10  26.001 ± 5.210  ms/op
Blackbird.beanArrayDeser             ss   10  26.777 ± 4.589  ms/op
Vanilla.beanArrayDeser               ss   10  31.012 ± 5.982  ms/op

Afterburner.beanArraySer             ss   10   3.301 ± 1.122  ms/op
Blackbird.beanArraySer               ss   10   3.956 ± 1.089  ms/op
Vanilla.beanArraySer                 ss   10   3.625 ± 1.376  ms/op

Afterburner.classicBeanItemDeser     ss   10   5.510 ± 1.597  ms/op