Robbyn Rahmandaru robzlabz

TF-1648 — ACP Consultations Sales Report ignores partial refunds

Status: PASS on staging (deployed revision matches PR #1418 merge commit) Tested 2026-11-02 against https://web-stg.motmaina.com/acp.

1. What the defect is

application/modules/acp/models/Sales_reports_model.php computed the three "paid" figures of the Consultations Sales Report straight from the booking row:

TF-941 — how every figure is calculated

Three write stages produce the stored rows, and one read stage only sums them. Nothing on the report scans customer_consultations, appointment_activities, consultants_schedule, customers or consultants_ratings at read time.

customer_consultations / appointment_activities / consultants_schedule / consultants_ratings / …
        │
        │ ①  close consultation (closed_at stamped) + 15-minute safety sweep

PR #661 — bukti database: recompute setelah reschedule mencampur dua occurrence

Review lengkap: REQUEST CHANGES — motmaina/backend PR #661 (fix/stale-metrics, head 1e0148cc).

Ringkas: PR ini menghapus row consultant_performance_metrics saat booking yang sudah Closed di-reschedule/transfer, supaya job 15 menit menghitung ulang. Idenya benar. Masalahnya: saat menghitung ulang, job mengambil data kehadiran untuk seluruh booking itu, bukan hanya sesi yang baru — jadi angka penggantinya bukan cuma "kurang pas", tapi mustahil.

Where the fix breaks

TF-462 — PHP 8.3 page sweep (163 pages, all HTTP 200)

Captured on robzlabz/tf-462-php83-fixes (PR #1433) running PHP 8.3.36, against the local motmaina_website clone.

Every ACP capture was taken after a real login through /acp/login (admin robzlabz@gmail.com). The capture script asserts the final URL of each ACP page is not /acp/login before the shot, and re-logs in if the session ever dropped. No image in this gist is a login screen.

163 pages. Public site: 163 · ACP (authenticated): 0.

	-- =============================================================================
	-- Migration: Remove Legacy "Immediate Consultations" Menu (TF-887)
	-- File: sidebar2.sql
	--
	-- Removes the legacy booking-log menu item (acp/consultations/immediateConsultations),
	-- its RBAC menu-action mappings, and associated role permissions.
	-- Safe and idempotent to execute multiple times.
	-- =============================================================================

	SET NAMES utf8mb4;

	-- =============================================================================
	-- Migration: Add RBAC Menus, Website Features, Permissions, and Localization
	-- Diff: stg-v2 compared to master (PR #1161)
	--
	-- This script contains all RBAC menus, website_features, rbac_menu_actions,
	-- rbac_roles_permissions, and associated sidebar localizations introduced
	-- in stg-v2. Idempotent (safe to run multiple times).
	-- =============================================================================

	SET NAMES utf8mb4;

	-- Motmaina Localization Table SQL Migration (Complete & Cleaned)
	-- Fully translated English & Arabic without any _en / _ar placeholders
	-- Idempotent: INSERT if Key does not exist, and UPDATE if Key already exists.

	SET NAMES utf8mb4;

	INSERT INTO `localization` (`Key`, `String_en`, `String_ar`, `Created_at`)
	SELECT '2', 'Password', 'كلمة المرور', '2020-04-20 04:14:30'
	WHERE NOT EXISTS (SELECT 1 FROM `localization` WHERE `Key` = '2');
	UPDATE `localization`

	-- Localization table data export
	-- Idempotent: only inserts if Key does not already exist

	SET NAMES utf8mb4;

	INSERT INTO `localization` (`Key`, `String_en`, `String_ar`, `Created_at`)
	SELECT '2', 'Password', 'كلمة المرور', '2020-04-20 04:14:30'
	WHERE NOT EXISTS (SELECT 1 FROM `localization` WHERE `Key` = '2');

	INSERT INTO `localization` (`Key`, `String_en`, `String_ar`, `Created_at`)